refactor: Upgrade to Pydantic v2 #1566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
859455c to
47951bb
Compare
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
47951bb to
03c9489
Compare
|
Bencher Report| Branch | refactor/pydantic-v2 |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.41 m(-18.01%)Baseline: 1.71 m | 1.54 m (109.76%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.41 m(-18.01%)Baseline: 1.71 m | 1.54 m (109.76%) | 2.06 m (68.33%) |
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
517d775 to
7250d52
Compare
msbrogli
commented
Jan 22, 2026
| db_basic_settings = db_settings.copy(deep=True, exclude={'features'}) | ||
| new_basic_settings = new_settings.copy(deep=True, exclude={'features'}) | ||
| db_settings: FeatureActivationSettings = FeatureActivationSettings.model_validate_json(db_settings_bytes) | ||
| db_basic_settings = db_settings.model_copy(deep=True, update={'features': {}}) |
Member
Author
There was a problem hiding this comment.
I'd rather use exclude instead of update.
Member
Author
There was a problem hiding this comment.
It seems exclude is not available in Pydantic v2. I guess it is ok to simply replace it by an empty dict.
msbrogli
commented
Jan 22, 2026
|
|
||
| class SideDagArgs(RunNodeArgs): | ||
| poa_signer_file: str | None | ||
| poa_signer_file: str | None = None |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
- Coverage 85.80% 85.72% -0.08%
==========================================
Files 439 439
Lines 33758 33723 -35
Branches 5276 5277 +1
==========================================
- Hits 28966 28909 -57
- Misses 3784 3802 +18
- Partials 1008 1012 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
107d6c4 to
d0ac1fe
Compare
msbrogli
commented
Jan 22, 2026
Comment on lines
+133
to
+134
| token_name: Optional[str] = None | ||
| token_symbol: Optional[str] = None |
Member
Author
There was a problem hiding this comment.
Pydantic v2 requires default value to ignore missing parameters. Should these None be included?
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
d0ac1fe to
84527e6
Compare
glevco
reviewed
Jan 27, 2026
Comment on lines
+25
to
+26
| class BaseEvent(BaseModel): | ||
| model_config = ConfigDict(use_enum_values=True) |
Contributor
There was a problem hiding this comment.
Previous code set use_enum_values in addition to what's already configured on our BaseModel. Does this new syntax do that, too, instead of replacing all configs?
| for feature, criteria in self.features.items() | ||
| } | ||
| # Use object.__setattr__ because the model is frozen | ||
| object.__setattr__(self, 'features', validated_features) |
Contributor
There was a problem hiding this comment.
There's probably a better way to do this, instead of using __setattr__. Maybe it's a use case for mode='before'?
| @@ -1,4 +1,4 @@ | |||
| # This file is automatically @generated by Poetry 2.3.1 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.1.3 and should not be changed by hand. | |||
Contributor
There was a problem hiding this comment.
Use the most recent Poetry version
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
84527e6 to
eaa0320
Compare
msbrogli
force-pushed
the
refactor/pydantic-v2
branch
from
eaa0320 to
cc58057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR upgrades the codebase from Pydantic v1 to Pydantic v2.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged